Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added channel updating operation #307

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

zhuyuanmao
Copy link
Member

@zhuyuanmao zhuyuanmao commented Aug 27, 2021

add an update method to channel class to achieve updating operation such as add org to the channel.

Signed-off-by: Yuanmao Zhu zhu.yuanmao18@gmail.com

add an update method to channel class to achieve updating operation.

Signed-off-by: Yuanmao Zhu <zhu.yuanmao18@gmail.com>
@zhuyuanmao zhuyuanmao requested a review from a team August 27, 2021 21:28

def update(self, channel, channel_tx, orderer_url, time_out="90s"):
try:
res = os.system("{} channel create -c {} -f {} -o {} --timeout {}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's "create"?

fetching command allows us to get the newest block so that we can use it to
update channel later.

Signed-off-by: Yuanmao Zhu <zhu.yuanmao18@gmail.com>
Yuanmao Zhu added 2 commits August 30, 2021 22:41
Signed-off-by: Yuanmao Zhu <zhu.yuanmao18@gmail.com>
Signed-off-by: Yuanmao Zhu <zhu.yuanmao18@gmail.com>
@yeasy yeasy merged commit 908ded2 into hyperledger:main Sep 1, 2021
@zhuyuanmao zhuyuanmao deleted the channel-updating branch September 10, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants