Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#issue-313] cmdline lib function list and getinfo has no info return #314

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

tianxuanhong
Copy link
Contributor

Added information processing of function list and function getinfo

Close #issue-313

Signed-off-by: zhaoshihong523713078@qq.com

Added information processing of function list and function getinfo

Close #issue-313

Signed-off-by: tianxuanhong <523713078@qq.com>
@tianxuanhong tianxuanhong requested a review from a team September 2, 2021 08:06
Copy link
Contributor

@XuHugo XuHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value is better in a canonical format than in packaging the terminal's data back.

For example:
~$ peer channel list

2018-02-25 14:21:20.361 UTC [channelCmd] InitCmdFactory -> INFO 003 Endorser and orderer connections initialized
Channels peers has joined:
mychannel
2018-02-25 14:21:20.372 UTC [main] main -> INFO 006 Exiting.....

We just need “mychannel”。
In addition, this part is not in a hurry, you can first complete the create function.

@tianxuanhong
Copy link
Contributor Author

I modified the return data again。
Getinfo returns blockinfo in JSON format, and list only returns the list of added channels

cmdline lib function list and getinfo has no info return

Close #issue-313

Signed-off-by: tianxuanhong <523713078@qq.com>
@XuHugo XuHugo merged commit d183e75 into hyperledger:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants