Enable Github CI for Code Check #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create yml file to run the code check CI. - Fix version of eslint-plugin-import to avoid a known bug in it. - Replace `make docker` in Makefile with new commands. Signed-off-by: Xichen Pan <xichen.pan@gmail.com>
yeasy
approved these changes
Jul 26, 2022
|
Now CI testing will be triggered with new commit. |
xichen1
added a commit
to xichen1/cello
that referenced
this pull request
Sep 9, 2022
In hyperledger#472, the tox github action plugin was not configued correctly. That results some missing code format problems in the following PRs. This PR adds the correct configuration to tox.ini file and fixs the missed code format problems. Signed-off-by: Xichen Pan <xichen.pan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make dockerin Makefile with new commands.Signed-off-by: Xichen Pan xichen.pan@gmail.com