Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stub getTxTimestamp() and getDateTimestamp() functions #404

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

bestbeforetoday
Copy link
Member

These were not interpreted correctly from the protocol buffer transaction timestamp.

Closes #400

@bestbeforetoday bestbeforetoday marked this pull request as ready for review June 14, 2023 21:09
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner June 14, 2023 21:09
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) June 16, 2023 09:02
@bestbeforetoday bestbeforetoday force-pushed the timestamp branch 2 times, most recently from ad4a6d5 to 9e3991a Compare June 16, 2023 09:45
mbwhite
mbwhite previously approved these changes Jun 16, 2023
Copy link
Member

@mbwhite mbwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

These were not interpreted correctly from the protocol buffer transaction timestamp.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday
Copy link
Member Author

Resolved a merge conflict in pnpm-lock.yaml. No other changes.

@bestbeforetoday bestbeforetoday merged commit 753bf8a into hyperledger:main Jun 16, 2023
4 checks passed
@bestbeforetoday bestbeforetoday deleted the timestamp branch April 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong getTxTimestamp
2 participants