[FAB-17950] Implement removal of orderer endpoints from toplevel channel #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephyee
force-pushed
the
fab-17950
branch
3 times, most recently
from
292280e to
f15bf3a
Compare
wlahti
reviewed
Jun 11, 2020
config Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
caod123
reviewed
Jun 11, 2020
|
|
||
| // RemoveLegacyOrdererAddresses removes the deprecated top level orderer addresses config key and value | ||
| // from the channel config. | ||
| // In fabric 1.4, top level orderer addresses were migrated to the org level orderer endpoints |
There was a problem hiding this comment.
nit: period at end of sentence :p
caod123
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Implement removal of orderer addresses from the top level of a new ConfigTx's channel group to remove the legacy config value.
Related issues
FAB-17950