[FAB-18268] Add SetPolicies() to easily replace multiple policies in an existing configuration with the given policies #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng configuration with the given ones Currently, setPolicies() upserts policies in an existing configuration with the given ones. This speficifation makes it difficult to remove multiple policies that are not needed. In preparation for supporting SetPolicies() for groups and orgs, this patch modifies setPolicies() to clear all existing policies in an existing configuration and then replace them with the given policies. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for a channel group in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for an application group in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for an orderer group in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for an application org in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for an orderer org in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
This patch adds SetPolicies() to easily replace multiple policies for a consortium org in an existing configuration with the given ones. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
caod123
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Originally when the API was designed, we considered having a bulk policy update for the entire policies field but then decided to scrap it after being unable to come up with use cases for it outside of adding or removing single policies. If this change satisfies any use cases that are more convenient for you, then we welcome the contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds SetPolicies() to easily replace multiple policies for groups and orgs in an existing configuration with the given policies.
Type of change
Description
This patch adds SetPolicies() to easily replace multiple policies for groups and orgs in an existing configuration with the given policies.
Targets to add the new functions:
By providing functions to replace multiple policies in bulk, users can change multiple policies with a single function call, so users should not need a tedious method (e.g., repeat SetPolicy() and RemovePolicy() for a group to be replaced).
As preparation for supporting SetPolicies() for groups and orgs, this patch modifies setPolicies() in configtx/policies.go in to clear all existing policies in an existing configuration and then replace them with the given policies.
Also, this patch fixes minor typos in comments.
Related issues