Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17140] Add go commercial paper contract #102

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

awjh-ibm
Copy link
Contributor

Resolves FAB-17140

Creates:
Go contract for magnetocorp and digibank

Adds:
Unit and Integration Tests for Go contracts in CI
Additional documentation on using Go contract

Copy link

@sstone1 sstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the comment from @mbwhite

@awjh-ibm awjh-ibm force-pushed the FAB-17140 branch 3 times, most recently from ade164c to d9b3dd0 Compare January 17, 2020 10:01
Signed-off-by: Andrew Hurt <andrew.hurt1@ibm.com>
Copy link
Member

@mbwhite mbwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbwhite mbwhite dismissed sstone1’s stale review January 24, 2020 14:12

already actioned

@mbwhite mbwhite merged commit 5b93dd0 into hyperledger:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants