Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17268] Move fabcar sample to test network #103

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

nikhil550
Copy link
Contributor

@nikhil550 nikhil550 commented Jan 17, 2020

Signed-off-by: NIKHIL E GUPTA negupta@us.ibm.com

Moving fabcar from byfn to the new test network.

  • Using the CAs supported natively by the test network
  • Using the scripts provided by the test network and remove the chaincode deployment in startFabric.sh
  • Change connection profile path
  • user1 > appUser since user 1 is already registered with the CA
  • Adding a stopFabric.sh script so users do not have to change directories.

Related Issues:
This update to the sample corresponds to this update to the first app tutorial: hyperledger/fabric#522
The two should be merged together.

@lehors
Copy link
Contributor

lehors commented Jan 17, 2020

/azp run

@robmurgai
Copy link

@nikhil550 In the description I see user1 > fabcarUser since user 1 is already registered with the CA, . . in RegisterUser.java, invoke.js I see the user listed as "appuser".

@nikhil550
Copy link
Contributor Author

@nikhil550 In the description I see user1 > fabcarUser since user 1 is already registered with the CA, . . in RegisterUser.java, invoke.js I see the user listed as "appuser".

I originally had fabcarUser, but changed it to a better name for the tutorial. Forgot to update the PR comment.

@nikhil550 nikhil550 force-pushed the FAB-17268 branch 2 times, most recently from dccca52 to 9856875 Compare February 8, 2020 18:20
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 103 in repo hyperledger/fabric-samples

@lindluni
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 103 in repo hyperledger/fabric-samples

@lindluni
Copy link
Contributor

/azp run

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All good!

@lehors lehors merged commit 87600bd into hyperledger:master Mar 30, 2020
@nikhil550 nikhil550 deleted the FAB-17268 branch March 30, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants