Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript HSM sample application #1086

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Update TypeScript HSM sample application #1086

merged 2 commits into from
Sep 19, 2023

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Sep 7, 2023 •
edited
Loading

  • Update to Node 16.
  • Simplify SKI code using Node standard packages and avoiding use of jsrsasign.

Also fix multiple existing build breakages.

@bestbeforetoday
Update TypeScript HSM sample application
1bd3f70 
- Update to Node 16.
- Simplify SKI code using Node standard packages and avoiding use of jsrsasign.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday
Fixes for build breakages
558a0b8 
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review September 18, 2023 12:46
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner September 18, 2023 12:46
@bestbeforetoday
Copy link
Member Author

bestbeforetoday commented Sep 18, 2023 •
edited
Loading

@hyperledger/fabric-samples-maintainers I think this PR is ready for review. My intention was to deliver a small tidy up of the HSM sample but, when doing so, I discovered that large numbers of samples were failing in the build. I have fixed the majority of them in the second commit associated with this PR. The remaining failures are in Kubernetes deployment of the Full Stack Asset Transfer Guide. I do not know what changes are required to fix this failure.

denyeart
denyeart approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bestbeforetoday !

@denyeart denyeart merged commit 6e71f63 into hyperledger:main Sep 19, 2023
38 of 41 checks passed
@jkneubuhl
Copy link

Hi @bestbeforetoday and @denyeart

Sorry about the test failures falling off the vine. It looks like there may have been a little bit of drift for the version of kind that is used by the test suite / sample app. The binaries are pinned to a slightly out of date revision of kind / kubernetes (1.24.x) and it may be having troubles coming up on the latest github test runners. The kind / kube clients are up to 1.28.x.

@satota2 satota2 mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyeart denyeart denyeart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bestbeforetoday @jkneubuhl @denyeart