Update Go gRPC dependency #1191
Conversation
grpc.Dial() is (soon to be) deprecated in current gRPC versions. Use grpc.NewClient() instead. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
grpc-newclient
branch
from
47da819
to
152c79c
Compare
There was a problem hiding this comment.
Hello @bestbeforetoday ,
Thank you for submitting this PR. I have a question about the NewClient() function. It seems like it would work just specifying localhost:port for the endpoint. Is there a specific need to include dns:///? Since 'dns' is used by default, I thought it might not be necessary to specify it explicitly. I'm not very familiar with the newer implementations of NewClient() in gRPC, so I would appreciate if you could share any practices or reasoning behind this choice.
Other that, LGTM!
|
If no URI scheme is specified, dns is used by default. The documentation does specify that the argument should be a URI and gives an example using the |
There was a problem hiding this comment.
@bestbeforetoday
Thank you for your response. I understand now that specifying the schema explicitly is recommended in the documentation, so your code is appropriate.
grpc.Dial() is (soon to be) deprecated in current gRPC versions. Use grpc.NewClient() instead.