Remove legacy sample applications #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
remove-legacy
branch
9 times, most recently
from
1114bf8
to
508c611
Compare
bestbeforetoday
force-pushed
the
remove-legacy
branch
from
508c611
to
b5ac838
Compare
The removed samples make use of deprecated legacy client SDKs. They all have equivalent samples implemented using the currently supported Fabric Gateway client API, and are therefore redundant. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
remove-legacy
branch
from
b5ac838
to
6c8b5c7
Compare
denyeart
approved these changes
Jun 19, 2024
| ``` | ||
| cd fabric-samples/asset-transfer-basic/application-javascript | ||
| cd fabric-samples/asset-transfer-basic/application-gateway-go |
There was a problem hiding this comment.
Any reason to use application-gateway-go instead of application-gateway-typescript? It seems more new users are familiar with javascript/typescript which is probably why the old instructions used javascript.
There was a problem hiding this comment.
Any of the client application languages implementations will work fine. I figured that, since this chaincode sample uses Go, the Go client application probably made more sense. One language rather than two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed samples make use of deprecated legacy client SDKs. They all have equivalent samples implemented using the currently supported Fabric Gateway client API, and are therefore redundant.
Contributes to #1087