test-network deployCC.sh invoke chaincode inconsistency #123
Conversation
woodyjon
requested review from
christo4ferris,
denyeart,
harrisob,
jyellick,
lehors,
mastersingh24,
mbwhite and
sstone1
as code owners
|
But in fabcar, which is used by this script, there is no init function. The call to init (as it is in the test-network script in the "no TLS" case) does not work. |
|
HI @woodyjon, sorry for the delay. I asked around and it turns out I had this wrong. If you use the new fabric programing model, you can initialize the chaincode using any transaction in the chaincode. (usually this would be done with an empty instantiate or Init function added by the developer). This means that the second invoke can actually be removed. It also means that this PR can go ahead and be merged. |
|
OK, thanks for the clarification! |
|
@woodyjon Thanks for your contribution but we won't be able to merge it without a sign-off. Can you please amend your commit with a sign-off in the log? See https://hyperledger-fabric.readthedocs.io/en/master/CONTRIBUTING.html#legal-stuff |
|
I just added the sign-off message to the commits. Is it ok like so? |
|
The DCO check is still failing. Please, follow the instructions: |
Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com> Signed-off-by: Jon <woodyjon@gmail.com>
Change 2.0.0-beta to 2.0.0 when CommercialPaper uses the test network Add test network to the azure pipelines Correct test network envvar script Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Signed-off-by: Jon <woodyjon@gmail.com> Signed-off-by: Jonathan Gross <woodyjon@gmail.com>
Keep consistency of the function called in the "no TLS" and "with TLS" cases Signed-off-by: Jon <woodyjon@gmail.com> Signed-off-by: Jonathan Gross <woodyjon@gmail.com>
…ct one It was actually the other way around, it is the no TLS line which was wrong and should have ready `initLedger` instead of `init`. Signed-off-by: Jon <woodyjon@gmail.com> Signed-off-by: Jonathan Gross <woodyjon@gmail.com>
Keep consistency of the function called in the "no TLS" and "with TLS" cases Signed-off-by: Jonathan Gross <woodyjon@gmail.com> Signed-off-by: Jon <woodyjon@gmail.com> Signed-off-by: Jonathan Gross <woodyjon@gmail.com>
…ct one It was actually the other way around, it is the no TLS line which was wrong and should have ready `initLedger` instead of `init`. Signed-off-by: Jonathan Gross <woodyjon@gmail.com> Signed-off-by: Jon <woodyjon@gmail.com> Signed-off-by: Jonathan Gross <woodyjon@gmail.com>
|
There you go 😀 |
|
If needed, I can redo the PR more cleanly, with a single commit. |
|
No worries, we'll squash the commits. Thanks. |
|
Wait, now there are 87 files changed... something went wrong. |
|
Do I make a new PR? |
|
If that's easier for you then just do that. What's clear is that we can't merge this PR as it stands so something needs to be done. |
|
I close this PR because I messed it up. Cleaner PR is there: #141 |
Keep consistency of the function called in the "no TLS" and "with TLS" cases