[FAB-17504] add Organizations.<Org>.OrdererEndpoints and remove Orderer.Addresses #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuxuer
requested review from
christo4ferris,
denyeart,
harrisob,
jyellick,
lehors,
mastersingh24,
mbwhite and
sstone1
as code owners
|
Can you do a git fetch and git rebase on the latest master which includes the fixes for the failures you are seeing in CI |
…er.Addresses Description The use of Orderer.Addresses in configtx.yaml is deprecated, and Organizations.<Org>.OrdererEndpoints should be used instead. Therefore, update all the fabric-samples configtx.yaml files. Related issues https://jira.hyperledger.org/browse/FAB-17504 Signed-off-by: xu wu <wuxu1103@163.com>
I have done this and all checks hava passed. |
|
LGTM, tested locally ran well |
lehors
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of Orderer.Addresses in configtx.yaml is deprecated, and Organizations..OrdererEndpoints should be used instead. Therefore, update all the fabric-samples configtx.yaml files.
Related issues
https://jira.hyperledger.org/browse/FAB-17504
Signed-off-by: xu wu wuxu1103@163.com