Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enrollUser files to commercial paper #140

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

nikhil550
Copy link
Contributor

Signed-off-by: NIKHIL E GUPTA negupta@us.ibm.com

Add support for using CAs to enroll an application user to the commercial paper sample. This will allow the sample to use best practices for app development and move samples farther away from cryptogen.

With this change, both the old method of moving files into the wallet and the enrollUser.js files can be used to create the application user. The tutorial documentation can be updated to use the enroll file after this PR is merged. After the doc is updated, the program that creates a user from the file system can be removed. There would be no disruption in the user experience.

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants