Update java chaincode to be compatible with doc and other implementations #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Obermeier <scray@stefan-obermeier.de>
E.g. Return key of the queried record Signed-off-by: Stefan Obermeier <scray@stefan-obermeier.de>
obermeier
requested review from
christo4ferris,
denyeart,
harrisob,
jyellick,
lehors,
mastersingh24,
mbwhite and
sstone1
as code owners
lehors
suggested changes
Apr 6, 2020
There was a problem hiding this comment.
This looks good to me, unfortunately my java env is so broken I can't seem to be able to run this to check at the moment. Some spurious indentation and whitespaces seem to have got their way into these changes. Could you please fix those and check I'm not missing any others?
Thanks.
chaincode/fabcar/java/src/main/java/org/hyperledger/fabric/samples/fabcar/CarQueryResult.java
Outdated
Show resolved
Hide resolved
chaincode/fabcar/java/src/main/java/org/hyperledger/fabric/samples/fabcar/CarQueryResult.java
Outdated
Show resolved
Hide resolved
chaincode/fabcar/java/src/main/java/org/hyperledger/fabric/samples/fabcar/FabCar.java
Outdated
Show resolved
Hide resolved
chaincode/fabcar/java/src/main/java/org/hyperledger/fabric/samples/fabcar/FabCar.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The java implementation of the fabcar example is in some cases a little bit different from the doc and other implementations like go and javascript. Some aspects are discussed here
The key was updated to be compatible with the doc.
Query results contains the key of the record. Because it is printed very often in this tutorial.