Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize and Standardize ci Directory Content #152

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Organize and Standardize ci Directory Content #152

merged 1 commit into from
Apr 6, 2020

Conversation

lindluni
Copy link
Contributor

@lindluni lindluni commented Apr 5, 2020

This change organizes the ci directory into common-sense subfolders and standardizes pipelines naming schemes.

Also removes the dead Jenkins code in the ./scripts directory

Also creates a single entrypoint for specifying the version of Fabric to test against in the azure-pipelines.yml file which is propogated into each of the network launch filees.

Signed-off-by: Brett Logan brett.t.logan@ibm.com

@lindluni lindluni changed the title Organize and Standardize ci Directory Content Organize and Standardize ci Directory Content Apr 5, 2020
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would be nice to fix typo.

This change organizes the `ci` directory into common-sense
subfolders and standardizes pipelines naming schemes.

Also removes the dead Jenkins code in the `./scripts` directory

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
@lindluni lindluni requested a review from a team as a code owner April 6, 2020 19:55
@lindluni lindluni requested a review from lehors April 6, 2020 19:56
@lehors
Copy link
Contributor

lehors commented Apr 6, 2020

/azp run

1 similar comment
@lindluni
Copy link
Contributor Author

lindluni commented Apr 6, 2020

/azp run

@lehors
Copy link
Contributor

lehors commented Apr 6, 2020

Thanks!

@lehors lehors merged commit c572c51 into hyperledger:master Apr 6, 2020
@lindluni
Copy link
Contributor Author

lindluni commented Apr 6, 2020

It got hung up on an azure flake, I ended up having to force it from the Azure UI

@lindluni
Copy link
Contributor Author

lindluni commented Apr 6, 2020

Thanks Arnaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants