Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded abstore golang chaincode to use contract-api package #154

Merged
merged 2 commits into from
Apr 8, 2020
Merged

upgraded abstore golang chaincode to use contract-api package #154

merged 2 commits into from
Apr 8, 2020

Conversation

Zzocker
Copy link
Contributor

@Zzocker Zzocker commented Apr 8, 2020

upgraded abstore golang chaincode to use contract-api package.

Signed-off-by: Pritam Singh pkspritam10@gmail.com

upgraded abstore golang chaincode to use contract-api package
2436db0 
Signed-off-by: Pritam Singh <pkspritam10@gmail.com>
@Zzocker Zzocker requested a review from a team as a code owner April 8, 2020 03:51
lehors
lehors suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I think it's a good idea to upgrade our samples to use the higher level API and show people the better way of writing chaincode.
I've found a few problems that you can easily fix so this can be merged though.

chaincode/abstore/go/abstore.go Outdated Show resolved Hide resolved
chaincode/abstore/go/abstore.go Outdated Show resolved Hide resolved
chaincode/abstore/go/go.mod Outdated Show resolved Hide resolved
chaincode/abstore/go/go.mod Outdated Show resolved Hide resolved
resolved the issue
d493f6a 
Signed-off-by: Pritam Singh <pkspritam10@gmail.com>
lehors
lehors approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lehors lehors merged commit 381fb46 into hyperledger:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehors lehors lehors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zzocker @lehors