Remove TLS = false if statement in test network #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehors
reviewed
Apr 14, 2020
There was a problem hiding this comment.
SGTM but didn't you miss some related code that also ought to be removed?
$ git grep TLS_ENABLED
[...]
scripts/envVar.sh: if [ -z "$CORE_PEER_TLS_ENABLED" -o "$CORE_PEER_TLS_ENABLED" = "true" ]; then
scripts/org3-scripts/envVarCLI.sh: if [ -z "$CORE_PEER_TLS_ENABLED" -o "$CORE_PEER_TLS_ENABLED" = "true" ]; then
scripts/org3-scripts/step1org3.sh: if [ -z "$CORE_PEER_TLS_ENABLED" -o "$CORE_PEER_TLS_ENABLED" = "false" ]; then
Good catch. Removed these a well. Removed the |
Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NIKHIL E GUPTA negupta@us.ibm.com
The create Channel and deploy chaincode scripts contained an if statement on whether TLS was enabled for many commands
I assume this is left over from older versions of 1.x, and from Kafka or solo consensus. Since TLS is required for RAFT and other features, I removed the TLS not enabled option.