Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stop script to remove fabcar chaincode containers and images. #64

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Added stop script to remove fabcar chaincode containers and images. #64

merged 4 commits into from
Nov 29, 2019

Conversation

DanielRuthardt
Copy link

byfn.sh can only remove chaincode containers and images for mycc. Thus byfn.sh down, nor a future byfn.sh up, on its own, does not do a complete teardown of the fabcar network, the suggested script does.

The functions clearContainers and removeUnwantedImages have been copied from first-network's byfn.sh and have only been modified to address the fabcar chaincode instead of the mycc chaincode.

In order not to overload this PR, no attempts of making byfn.sh parameterizable in respect of the chaincode to install or to use during teardown have been made.

Signed-off-by: Daniel Ruthardt <druthardt@contractor.linuxfoundation.org>
Signed-off-by: Daniel Ruthardt <druthardt@contractor.linuxfoundation.org>
@stale
Copy link

stale bot commented Sep 26, 2019

Thank you for your contribution! Please use gerrit for the changes, see documentation here

@stale stale bot added the stale label Sep 26, 2019
@stale
Copy link

stale bot commented Sep 28, 2019

Thank you for your contribution! Please use gerrit for the changes, see documentation here

@stale stale bot closed this Sep 28, 2019
@ryjones ryjones reopened this Oct 27, 2019
@stale stale bot removed the stale label Oct 27, 2019
@ryjones ryjones requested a review from a team October 27, 2019 16:04
@stale
Copy link

stale bot commented Oct 27, 2019

Thank you for your contribution! Please use gerrit for the changes, see documentation here

@stale stale bot added the stale label Oct 27, 2019
@lindluni
Copy link
Contributor

/azp run

@stale stale bot removed the stale label Oct 27, 2019
@lindluni
Copy link
Contributor

/azp run

@lindluni
Copy link
Contributor

/azp run

@stale
Copy link

stale bot commented Nov 4, 2019

false

@stale stale bot added the stale label Nov 4, 2019
@ryjones ryjones removed the stale label Nov 5, 2019
@lindluni
Copy link
Contributor

/azp run

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry it took us so long to get to this. This is something that has been bugging me too so I welcome the contribution!

@lehors
Copy link
Contributor

lehors commented Nov 29, 2019

/azp run

@lehors lehors merged commit ba63e65 into hyperledger:release-1.4 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants