Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port numbers for peers in high-throughput #74

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Fix port numbers for peers in high-throughput #74

merged 1 commit into from
Nov 30, 2019

Conversation

danipisca07
Copy link

Updated ports number for peers connection to match the new docker setup used in version 1.4 (first-network sample)

image

@sstone1
Copy link

sstone1 commented Nov 15, 2019

@danipisca07 thanks for this PR - please can you fix the DCO failure by adding a sign off to your commit? The command git commit --amend -s will allow you to edit your last commit and the -s will add the correct Signed-off-by message to it. You will need to git push -f after doing this to update the PR.

@danipisca07
Fix port numbers for peers in high-throughput
cd5b68d 
Signed-off-by: danipisca07 <danielepiscaglia@libero.it>
@lehors
Copy link
Contributor

lehors commented Nov 29, 2019

/azp run

lehors
lehors approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@lehors lehors merged commit 0d7c7a1 into hyperledger:release-1.4 Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehors lehors lehors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danipisca07 @sstone1 @lehors