-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-16147] Update Commercial Paper to work with v2 #98
Conversation
1b21057
to
1ef8e56
Compare
Note: this is using the basic-network; have started moving this to test-network as it better represents the scenario, And we can better use the two languages |
...-paper/organization/magnetocorp/contract-java/src/main/java/org/example/ledgerapi/State.java
Outdated
Show resolved
Hide resolved
@@ -1,6 +1,7 @@ | |||
/* | |||
* SPDX-License-Identifier: Apache-2.0 | |||
* SPDX-License-Identifier: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No license identifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Apache-2.0 in a license header, and a few .class files have been checked in... other than that, looks good!
8c585c4
to
370b216
Compare
Update the applications and scripts to use the new v2 SDKs and the new lifecycle Add in a basic script based on the readme.md that does a basic run of the scenario Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the applications and scripts to use the new v2
SDKs and the new lifecycle
Add in a basic script based on the readme.md that does
a basic run of the scenario
Signed-off-by: Matthew B White whitemat@uk.ibm.com