Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-16147] Update Commercial Paper to work with v2 #98

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

mbwhite
Copy link
Member

@mbwhite mbwhite commented Jan 8, 2020

Update the applications and scripts to use the new v2
SDKs and the new lifecycle

Add in a basic script based on the readme.md that does
a basic run of the scenario

Signed-off-by: Matthew B White whitemat@uk.ibm.com

@mbwhite
Copy link
Member Author

mbwhite commented Jan 9, 2020

Note: this is using the basic-network; have started moving this to test-network as it better represents the scenario, And we can better use the two languages

@@ -1,6 +1,7 @@
/*
* SPDX-License-Identifier: Apache-2.0
* SPDX-License-Identifier:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No license identifier?

Copy link

@sstone1 sstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Apache-2.0 in a license header, and a few .class files have been checked in... other than that, looks good!

@mbwhite mbwhite force-pushed the update-cp branch 3 times, most recently from 8c585c4 to 370b216 Compare January 14, 2020 15:31
Update the applications and scripts to use the new v2
SDKs and the new lifecycle

Add in a basic script based on the readme.md that does
a basic run of the scenario

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Copy link

@sstone1 sstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sstone1 sstone1 merged commit 4c2a0a4 into hyperledger:master Jan 14, 2020
@mbwhite mbwhite deleted the update-cp branch January 27, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants