Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Conversation

@anonsachin
Copy link
Contributor

@anonsachin anonsachin commented Apr 13, 2022

As the Wallet struct's store field is unexported it cannot be set outside the gateway package. This pull request adds a simple function to make it possible to have a custom WalletStore's.

Signed-off-by: anonsachin <sachin94roxz@gmail.com>
@anonsachin anonsachin requested a review from a team April 13, 2022 10:05
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #230 (2df1292) into main (cbdc79f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   76.16%   76.15%   -0.02%     
==========================================
  Files         193      193              
  Lines       14075    14077       +2     
==========================================
  Hits        10720    10720              
- Misses       2387     2388       +1     
- Partials      968      969       +1     
Impacted Files Coverage Δ
pkg/gateway/filesystemwallet.go 71.79% <100.00%> (ø)
pkg/gateway/wallet.go 88.88% <100.00%> (+0.42%) ⬆️
pkg/util/concurrent/lazycache/lazycache.go 88.34% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdc79f...2df1292. Read the comment docs.

@anonsachin
Copy link
Contributor Author

As the Wallet struct's store field is unexported it cannot be set outside the gateway package. If attempted will get the following error

implicit assignment to unexported field store in gateway.Wallet literal

@andrew-coleman #185 this was the last pull request we had this discussion but I deleted that code hence I created a new one

@anonsachin anonsachin marked this pull request as draft April 13, 2022 13:30
@anonsachin anonsachin marked this pull request as ready for review April 13, 2022 13:30
@troyronda
Copy link
Contributor

@andrew-coleman

@andrew-coleman andrew-coleman merged commit e866365 into hyperledger:main Apr 28, 2022
@anonsachin
Copy link
Contributor Author

Hi,

There were a lot of changes merged into the codebase after the v1.0.0 release. But the pkg in the go docs page is still at v1.0.0 as the latest - Doc's.

can we bump up the version to something like v1.1.0 to make the changes more accessible to people using the package?

otherwise, they will have to do the following command which can be inconvenient and not a good way to keep track of the package in their codebases.

go get github.com/hyperledger/fabric-sdk-go@e8663655affacfe1448c1450ecef11e1c5703aa4

I have also raised an issue regarding this - https://github.com/hyperledger/fabric-sdk-go/issues/228 .
@troyronda and @andrew-coleman is it possible to do this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants