[loadgen] Close broadcast streams only after the workload has completed #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
changed the title
liran-funaro
changed the title
liran-funaro
changed the title
cendhu
approved these changes
Sep 17, 2025
| defer dCancel() | ||
| g, gCtx := errgroup.WithContext(dCtx) | ||
| for _, stream := range streams { | ||
| stream := stream |
Contributor
There was a problem hiding this comment.
The loop variable scope has been fixed since go 1.22 -- https://go.dev/blog/loopvar-preview#the-fix
Contributor
Author
There was a problem hiding this comment.
Great! I wasn't aware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This ensures that any pending messages in the stream’s internal queue are fully processed. Even if all transactions have already been submitted, additional time may be required for them to be transmitted.
Related issues