Metrics with Prometheus #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengur
force-pushed
the
metrics_with_prometheus
branch
15 times, most recently
from
92e4094 to
2965278
Compare
gengur
force-pushed
the
metrics_with_prometheus
branch
7 times, most recently
from
c0da60a to
4a2b772
Compare
gengur
force-pushed
the
metrics_with_prometheus
branch
4 times, most recently
from
b0a8d71 to
1d8b660
Compare
gengur
force-pushed
the
metrics_with_prometheus
branch
5 times, most recently
from
cad437c to
e28651a
Compare
gengur
force-pushed
the
metrics_with_prometheus
branch
7 times, most recently
from
c6080e5 to
9fcaa61
Compare
gengur
force-pushed
the
metrics_with_prometheus
branch
from
9fcaa61 to
48a6703
Compare
tock-ibm
reviewed
Oct 28, 2025
| RequestMaxBytes: config.SharedConfig.BatchingConfig.RequestMaxBytes, | ||
| ClientSignatureVerificationRequired: config.LocalConfig.NodeLocalConfig.GeneralConfig.ClientSignatureVerificationRequired, | ||
| Bundle: bundle, | ||
| MonitoringListenAddress: config.LocalConfig.NodeLocalConfig.GeneralConfig.ListenAddress + ":" + strconv.Itoa(int(config.LocalConfig.NodeLocalConfig.GeneralConfig.MonitoringListenPort)), |
There was a problem hiding this comment.
Lets have a separate listen address as well, define it in the local config.
Sometime we don't want the monitoring service to be exposed on the same address as the communication services, e.g. we want it on 127.0.01 while we set the communication interfaces to something public.
If the Monitoring address is missing (empty), use the regular GeneralConfig.ListenAddress.
| SubmitTimeout: config.LocalConfig.NodeLocalConfig.BatcherParams.SubmitTimeout, | ||
| BatchSequenceGap: types.BatchSequence(config.LocalConfig.NodeLocalConfig.BatcherParams.BatchSequenceGap), | ||
| ClientSignatureVerificationRequired: config.LocalConfig.NodeLocalConfig.GeneralConfig.ClientSignatureVerificationRequired, | ||
| MonitoringListenAddress: config.LocalConfig.NodeLocalConfig.GeneralConfig.ListenAddress + ":" + strconv.Itoa(int(config.LocalConfig.NodeLocalConfig.GeneralConfig.MonitoringListenPort)), |
There was a problem hiding this comment.
a separate listen address
| SigningPrivateKey: signingPrivateKey, | ||
| WALDir: DefaultConsenterNodeConfigParams(config.LocalConfig.NodeLocalConfig.FileStore.Path).WALDir, | ||
| BFTConfig: BFTConfig, | ||
| MonitoringListenAddress: config.LocalConfig.NodeLocalConfig.GeneralConfig.ListenAddress + ":" + strconv.Itoa(int(config.LocalConfig.NodeLocalConfig.GeneralConfig.MonitoringListenPort)), |
There was a problem hiding this comment.
a separate listen address
| Consenter: consenterFromMyParty, | ||
| UseTLS: config.LocalConfig.TLSConfig.Enabled, | ||
| ClientAuthRequired: config.LocalConfig.TLSConfig.ClientAuthRequired, | ||
| MonitoringListenAddress: config.LocalConfig.NodeLocalConfig.GeneralConfig.ListenAddress + ":" + strconv.Itoa(int(config.LocalConfig.NodeLocalConfig.GeneralConfig.MonitoringListenPort)), |
There was a problem hiding this comment.
a separate listen address
| // ListenPort is the port on which to bind to listen | ||
| ListenPort uint32 `yaml:"ListenPort,omitempty"` | ||
| // MonitoringListenPort is the port on which to expose the monitoring service | ||
| MonitoringListenPort uint32 `yaml:"MonitoringListenPort,omitempty"` |
There was a problem hiding this comment.
Lets also have MonitoringListenAddress.
Lets have a separate listen address as well, defined here.
Sometime we don't want the monitoring service to be exposed on the same interface as the communication services, e.g. we want it on 127.0.01 while we set the communication interfaces to something public.
If the MonitoringListenAddress address is missing (empty), use the regular GeneralConfig.ListenAddress.
gengur
force-pushed
the
metrics_with_prometheus
branch
2 times, most recently
from
aef3dc3 to
da9f901
Compare
Signed-off-by: Genady Gurevich <genadyg@il.ibm.com>
gengur
force-pushed
the
metrics_with_prometheus
branch
from
da9f901 to
00c09db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #185