admin policy integration #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: May.Buzaglo <May.Buzaglo@ibm.com>
MayRosenbaum
force-pushed
the
admin_policy_integration
branch
from
1f7df42 to
60f14b9
Compare
| // check, which although not strictly necessary, is a good sanity check, in case the router | ||
| // has not been configured with the right cert material. The additional overhead of the signature | ||
| // check is negligible, as this is the re-config path and not the normal path. | ||
| _, err = cs.verifier.VerifyStructureAndClassify(configRequest) |
Contributor
There was a problem hiding this comment.
the request's header type should be HeaderType_CONFIG now? we can check that
Contributor
Author
There was a problem hiding this comment.
Correct.
protoutil.CreateSignedEnvelope outputs an envelope with header type HeaderType_CONFIG and then I create a request with that envelope.
What do you mean by check it ?
SigFilter / MaxBytesFilter are not responsible for checking the header type.
Contributor
There was a problem hiding this comment.
VerifyStructureAndClassify should return this type in its first return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.