-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The GetSessionInfo call was added to the getSession function which retrieves a session from the pool. The call was used to validate the state of the session before using it to ensure it was still healthy. Unfortunately the call is exceedingly expensive with preliminary tests showing nearly a second to perform the single operation. With a transaction require requiring several signings it is possible for it to take several seconds for a transaction just to retrieve all of it signatures. This change reverts the call and in future implementations we can look into other ways of verifying if a session has become stale, perhaps by analyzing failed transaction error messages and ejecting the session on transaction failures. Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
- Loading branch information
1 parent
4f1e340
commit 2d63281
Showing
2 changed files
with
2 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters