-
Notifications
You must be signed in to change notification settings - Fork 8.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FAB-10951] race in TestUpdateRootsFromConfigBlock
Change the gossip pull engine to memoize the timeout configuration at construction instead of constantly retrieving it at runtime from viper. This resolves a race where TestUpdateRootsFromConfigBlock modifies the viper configuration causing a concurrent map modification race. Also add missing error assertions in TestUpdateRootsFromConfigBlock and update the formatting to be a bit more idiomatic. Change-Id: I094b7426e494bdcff00e156f9e804c58aceb9f06 Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
- Loading branch information
Showing
2 changed files
with
79 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters