Skip to content

Commit

Permalink
FAB-16399 Correct capabilities error message
Browse files Browse the repository at this point in the history
The error message for attempting to enable orderer endpoints erroneously
says first V2_0 capabilities must be enabled, when in fact this was
backported to the V1_4_2 capabilities.

Change-Id: I64f1ee6d1ed77938df5e00f52163c8a7763a4615
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
  • Loading branch information
Jason Yellick committed Aug 23, 2019
1 parent 1e54df2 commit 607de4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common/channelconfig/orderer.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func NewOrdererOrgConfig(orgName string, orgGroup *cb.ConfigGroup, mspConfigHand

if !channelCapabilities.OrgSpecificOrdererEndpoints() {
if _, ok := orgGroup.Values[EndpointsKey]; ok {
return nil, errors.Errorf("Orderer Org %s cannot contain endpoints value until V2_0+ capabilities have been enabled", orgName)
return nil, errors.Errorf("Orderer Org %s cannot contain endpoints value until V1_4_2+ capabilities have been enabled", orgName)
}
}

Expand Down
2 changes: 1 addition & 1 deletion common/channelconfig/realconfig_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func TestOrgSpecificOrdererEndpoints(t *testing.T) {
assert.NoError(t, err)

_, err = channelconfig.NewChannelConfig(cg)
assert.EqualError(t, err, "could not create channel Orderer sub-group config: Orderer Org SampleOrg cannot contain endpoints value until V2_0+ capabilities have been enabled")
assert.EqualError(t, err, "could not create channel Orderer sub-group config: Orderer Org SampleOrg cannot contain endpoints value until V1_4_2+ capabilities have been enabled")
})

t.Run("Without_Capability_NoOSNs", func(t *testing.T) {
Expand Down

0 comments on commit 607de4d

Please sign in to comment.