[FAB-7955] Deliver req. unexpectedly fails

Deliver requests unexpectedly fail when the authentication timewindow
is not set. This CR adds a default value of 15 minutes for the time
window to ensure that the deliver server does not default to 0 seconds.

Change-Id: I3332f2df8a868f7e7ea10de68329ce6c244efe46
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

core/peer/deliverevents.go

@@ -17,6 +17,7 @@ package peer
 
 import (
 	"runtime/debug"
+	"time"
 
 	"github.com/golang/protobuf/proto"
 	"github.com/hyperledger/fabric/common/deliver"
@@ -127,10 +128,15 @@ func (s *server) Deliver(srv peer.Deliver_DeliverServer) error {
 	return s.dh.Handle(deliver.NewDeliverServer(srvSupport, s.policyCheckerProvider(resources.BLOCKEVENT), s.sendProducer(srv)))
 }
 
-// NewDeliverEventsServer creates an peer.Deliver server to take to deliver block and filtered block events
+// NewDeliverEventsServer creates a peer.Deliver server to deliver block and
+// filtered block events
 func NewDeliverEventsServer(mutualTLS bool, policyCheckerProvider PolicyCheckerProvider, supportManager deliver.SupportManager) peer.DeliverServer {
 	timeWindow := viper.GetDuration("peer.authentication.timewindow")
-
+	if timeWindow == 0*time.Minute {
+		defaultTimeWindow := 15 * time.Minute
+		logger.Warningf("`peer.authentication.timewindow` not set; defaulting to %s", defaultTimeWindow)
+		timeWindow = defaultTimeWindow
+	}
 	return &server{
 		dh: deliver.NewHandlerImpl(supportManager, timeWindow, mutualTLS),
 		policyCheckerProvider: policyCheckerProvider,

orderer/common/localconfig/config.go

@@ -334,6 +334,10 @@ func (c *TopLevel) completeInitialization(configDir string) {
 			logger.Infof("General.LocalMSPID unset, setting to %s", defaults.General.LocalMSPID)
 			c.General.LocalMSPID = defaults.General.LocalMSPID
 
+		case c.General.Authentication.TimeWindow == 0*time.Minute:
+			logger.Infof("General.Authentication.TimeWindow unset, setting to %s", defaults.General.Authentication.TimeWindow)
+			c.General.Authentication.TimeWindow = defaults.General.Authentication.TimeWindow
+
 		case c.FileLedger.Prefix == "":
 			logger.Infof("FileLedger.Prefix unset, setting to %s", defaults.FileLedger.Prefix)
 			c.FileLedger.Prefix = defaults.FileLedger.Prefix