[FAB-17726] Properly handle malformed gossip envelopes #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a malformed envelope is read from the stream, an error is propagated synchronously up the stack. However, the envelope is unmarshaled into a nil message which is also propagated further up the stack asynchronously. Under very rare circumstances, the error is picked up later than the message, and a nil pointer panic occurs. This patch fixes this by returning early in case of an error. Change-Id: Ia17767ec2483d83d5fa4e7e22514c539232108a8 Signed-off-by: yacovm <yacovm@il.ibm.com>
yacovm
changed the title
C0rWin
approved these changes
Apr 9, 2020
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 15, 2020
If a malformed envelope is read from the stream, an error is propagated synchronously up the stack. However, the envelope is unmarshaled into a nil message which is also propagated further up the stack asynchronously. Under very rare circumstances, the error is picked up later than the message, and a nil pointer panic occurs. This patch fixes this by returning early in case of an error. Change-Id: Ia17767ec2483d83d5fa4e7e22514c539232108a8 Signed-off-by: yacovm <yacovm@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a malformed envelope is read from the stream, an error is propagated
synchronously up the stack.
However, the envelope is unmarshaled into a nil
message which is also propagated further up the stack asynchronously.
Under very rare circumstances, the error is picked up later than
the message, and a nil pointer panic occurs.
This patch fixes this by returning early in case of an error.
Change-Id: Ia17767ec2483d83d5fa4e7e22514c539232108a8
Signed-off-by: yacovm yacovm@il.ibm.com