[FAB-17864] DropApplicationDBs should return error when createCouchInstance fails #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cendhu
suggested changes
May 11, 2020
core/ledger/kvledger/txmgmt/statedb/statecouchdb/couchdbutil_test.go
Outdated
Show resolved
Hide resolved
…stance fails Fix DropApplicationDBs to return error when getting an error from createCouchInstance. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
cendhu
approved these changes
May 11, 2020
manish-sethi
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
Fix DropApplicationDBs to return error when getting an error from
createCouchInstance. Also set CouchDB config to limit the number
of retries.
Related issues
https://jira.hyperledger.org/browse/FAB-17864