FAB-17890 Ch.Part.API: allow registrar to list a single channel #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the ChannelInfo(..) method in the registrar that looks up a channel in the chains map and reports extended information on its status. For this end we have to introduce the follower.Chain and augment existing cluster type chains with means of reporting their status. - Introduce the skeleton a new type of consensus.Chain implementation: follower.Chain. This will be created and run when the orderer is required to follow the cluster and pull blocks from other orderers. - The plan (for future commits) is for the follower.Chain to trigger the creation of an etcdraft.Chain when it discovers the orderer was added to the cluster, and vise versa; the etcdraft.Chain will replace itself with a follower.Chain when the orderer is removed from the cluster. - Introduce a new interface that cluster-type chains implement, that allows them to report their relation to the cluster and their status. This is done because the registrar is not aware of the exact type of the chains it is keeping. The registrar cannot reflect on the type as well, as this will cause an import cycle (due to the etcdraft package importing multichannel). Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ia454f47f04a8ba3dcd76886a5919d1c734c01015
yacovm
reviewed
Jun 1, 2020
yacovm
reviewed
Jun 1, 2020
yacovm
reviewed
Jun 1, 2020
Add typed constatnts for the possible values of ChannelInfo.Status & ChannelInfo.ClusterRelation. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I71062b944d4e5236c4df1462fa73740b68e2065b
yacovm
reviewed
Jun 1, 2020
Document types.ClusterRelation and types.Status. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I8171e6cfe6c3a137e7f1f48a14d1b2fe7f1aea5a
yacovm
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ChannelInfo(..) method in the registrar that looks up
a channel in the chains map and reports extended information on its
status. For this end we have to introduce the follower.Chain and
augment existing cluster type chains with means of reporting their
status.
Introduce the skeleton a new type of consensus.Chain
implementation: follower.Chain. This will be created and run when
the orderer is required to follow the cluster and pull blocks from
other orderers.
The plan (for future commits) is for the follower.Chain to trigger
the creation of an etcdraft.Chain when it discovers the orderer was
added to the cluster, and vise versa; the etcdraft.Chain will replace
itself with a follower.Chain when the orderer is removed from the
cluster.
Introduce a new interface that cluster-type chains implement, that
allows them to report their relation to the cluster and their status.
This is done because the registrar is not aware of the exact type of
the chains it is keeping. The registrar cannot reflect on the type
as well, as this will cause an import cycle (due to the etcdraft
package importing multichannel).
Signed-off-by: Yoav Tock tock@il.ibm.com
Change-Id: Ia454f47f04a8ba3dcd76886a5919d1c734c01015
Type of change
Related issues
Task: FAB-17980
Story: FAB-17824
Epic: FAB-17712