[FAB-8443] Update sampleconfig chaincodeAddress comments #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sykesm
reviewed
Jun 10, 2020
| @@ -30,7 +30,7 @@ peer: | |||
| # The endpoint the chaincode for this peer uses to connect to the peer. | |||
| # If this is not specified, the chaincodeListenAddress address is selected. | |||
| # And if chaincodeListenAddress is not specified, address is selected from | |||
| # peer listenAddress. | |||
| # peer address (see below). | |||
| # chaincodeAddress: 0.0.0.0:7052 | |||
|
|
|||
| # When used as peer config, this represents the endpoint to other peers | |||
There was a problem hiding this comment.
Is it possible to extend this explanation a bit? In particular, how it relates to addressAutoDetect?
Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
caod123
approved these changes
Jun 15, 2020
sijocherian
pushed a commit
to sijocherian/fabric
that referenced
this pull request
Jun 28, 2020
…#1386) Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Update chaincodeAddress comments in sample config core.yaml to reflect the implementation
Related issues
FAB-8443