Private data optimization: purge transient store in background #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gossip/privdata/coordinator_test.go
Outdated
Comment on lines
1186
to
1179
| assertPurged("tx1", "tx2") | ||
| assert.NoError(t, err) | ||
| assertCommitHappened() | ||
| purgedTxns = []string{"tx1", "tx2"} | ||
| require.Eventually(t, assertPurgedTxns, 2*time.Second, 100*time.Millisecond) |
There was a problem hiding this comment.
I find this change reducing the readability by isolating the parameters from the function. I feel that a better change would be func() bool { return assertPurgedTxns("tx1", "tx2") } (as you have done for the other function below).
There was a problem hiding this comment.
Agree. I was struggling but your suggestion didn't strike my mind.
func() bool { return assertPurgedTxns("tx1", "tx2") } simplifies everything.
gossip/privdata/coordinator_test.go
Outdated
Comment on lines
1729
to
1717
| assertPurged(false) | ||
| purged = false | ||
| require.Eventually(t, assertPurged, 2*time.Second, 100*time.Millisecond) |
There was a problem hiding this comment.
same comment as above
Signed-off-by: senthil <cendhu@gmail.com>
cendhu
force-pushed
the
private-optimization-bg-purge-transient
branch
from
d462737 to
3075de9
Compare
manish-sethi
approved these changes
Jun 17, 2020
sijocherian
pushed a commit
to sijocherian/fabric
that referenced
this pull request
Jun 28, 2020
Signed-off-by: senthil <cendhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
By purging entries present in the transient store in the background, we can improve the overall throughput of private data collection by 22%
Related issues
sub-task https://jira.hyperledger.org/browse/FAB-17986
story https://jira.hyperledger.org/browse/FAB-17984