[FAB-17992] Remove ledger blockstore data for a channel #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cendhu
suggested changes
Jun 19, 2020
wenjianqiao
force-pushed
the
fab17992
branch
4 times, most recently
from
9e71074 to
1fb4e29
Compare
|
@cendhu Thank you. I have addressed your comments. |
Add a Remove function to block store provider to remove block index and blocks directory for a channel. It will be called by the orderer and peer as part of channel deletion. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
cendhu
approved these changes
Jun 26, 2020
| if err := dbHandle.DeleteAll(); err != nil { | ||
| return err | ||
| } | ||
| dbHandle.Close() |
There was a problem hiding this comment.
Nit. Can be deferred after getting the handle.
There was a problem hiding this comment.
dbHandle.Close() removes dbHandle from provider's dbHandles map, so it is only called after DeleteAll is successful.
|
Got intermittent failure and opened FAB-18030. 2020-06-26T12:40:02.0392904Z Waiting for: 2020-06-26T12:40:02.0393318Z Removing member: Endpoint: 127.0.0.1:21514�[0m 2020-06-26T12:40:02.0393516Z 2020-06-26T12:40:02.0393800Z /home/vsts/work/1/go/src/github.com/hyperledger/fabric/integration/gossip/gossip_test.go:343 |
sijocherian
pushed a commit
to sijocherian/fabric
that referenced
this pull request
Jun 28, 2020
…1423) Add a Remove function to block store provider to remove block index and blocks directory for a channel. It will be called by the orderer and peer as part of channel deletion. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
Add a Remove function to block store provider to remove block index
and blocks directory for a channel. It will be called by the orderer
and peer as part of channel deletion.
Additional details
This PR adds the remove function to remove the block indexes and blocks dir for the channel. It is expected that the higher level above block store to handle failure recovery.
The PR is based on the current
BlockStoreProviderdesign.The opened
BlockStorefor the removed channel should not be used any more because it will return invalid data. If needed, we will close the blockstore and make it unusable in a separate PR.Related issues
Story: https://jira.hyperledger.org/browse/FAB-17992
Epic: https://jira.hyperledger.org/browse/FAB-17712