Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve peer CLI error message when no orderer address passed #1555

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Improve peer CLI error message when no orderer address passed #1555

merged 1 commit into from
Jul 8, 2020

Conversation

denyeart
Copy link
Contributor

@denyeart denyeart commented Jul 8, 2020

For peer CLI commands that require an orderer address, the peer
command does best effort attempt to retrieve orderer address from channel
config if the orderer address is not passed (it currently only
checks the deprecated Orderer.Addresses, not the org level
OrdererEndpoints). The best effort attempt may be removed in
a future release, so for now improve the error message
to indicate that orderer address should be passed using
-o flag.

Signed-off-by: David Enyeart enyeart@us.ibm.com

For peer CLI commands that require an orderer address, the peer
does best effort attempt to retrieve orderer address from channel
config if the orderer address is not passed (it currently only
checks the deprecated Orderer.Addresses, not the org level
OrdererEndpoints). The best effort attempt may be removed in
a future release, so for now improve the error message
to indicate that orderer address should be passed using
-o flag.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@denyeart denyeart requested a review from a team as a code owner July 8, 2020 03:05
@denyeart
Copy link
Contributor Author

denyeart commented Jul 8, 2020

@Mergifyio backport release-2.2

@mergify
Copy link

mergify bot commented Jul 8, 2020

Command backport release-2.2: pending

Waiting for the pull request to get merged

@caod123 caod123 merged commit 6ef8f3d into hyperledger:master Jul 8, 2020
mergify bot pushed a commit that referenced this pull request Jul 8, 2020
For peer CLI commands that require an orderer address, the peer
does best effort attempt to retrieve orderer address from channel
config if the orderer address is not passed (it currently only
checks the deprecated Orderer.Addresses, not the org level
OrdererEndpoints). The best effort attempt may be removed in
a future release, so for now improve the error message
to indicate that orderer address should be passed using
-o flag.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
(cherry picked from commit 6ef8f3d)
@mergify
Copy link

mergify bot commented Jul 8, 2020

Command backport release-2.2: success

Backports have been created

denyeart added a commit that referenced this pull request Jul 8, 2020
For peer CLI commands that require an orderer address, the peer
does best effort attempt to retrieve orderer address from channel
config if the orderer address is not passed (it currently only
checks the deprecated Orderer.Addresses, not the org level
OrdererEndpoints). The best effort attempt may be removed in
a future release, so for now improve the error message
to indicate that orderer address should be passed using
-o flag.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
(cherry picked from commit 6ef8f3d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants