Raft: Check suspect info once per suspect interval #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jul 14, 2020
| @@ -60,6 +61,9 @@ func (pc *PeriodicCheck) check() { | |||
| } | |||
|
|
|||
| func (pc *PeriodicCheck) conditionNotFulfilled() { | |||
| if pc.ReportCleared != nil && pc.conditionHoldsSince != (time.Time{}) { | |||
There was a problem hiding this comment.
maybe instead of:
pc.conditionHoldsSince != (time.Time{}
do:
pc.conditionHoldsSince.IsZero() ?
There was a problem hiding this comment.
Sure -- that is quite a bit more graceful, will fix.
Today's existing suspect logic has a periodic checker, which checks every 10s if the Raft cluster still has quorum. If the cluster has lost quorum, it marks the time this event begins, then, every 10s checks to see if 'enough' time has elapsed since the quorum was lost to suspect that the OSN has been evicted. If the OSN has not been evicted, or cannot determine its eviction status, then every 10s the OSN attempts to re-check its suspicion status, which can lead to large volumes of network traffic, especially in significiantly multichannel environments. This commit modifies the logic to track the number of times that the suspect checking logic has actually executed, to ensure that we check no more than once every suspect interval (by default every 10m, instead of every 10s). Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
jyellick
force-pushed
the
raft-suspect-interval
branch
from
771e51c to
8b3eef0
Compare
yacovm
approved these changes
Jul 14, 2020
|
@Mergifyio backport release-2.2 |
|
@Mergifyio backport release-2.1 |
|
@Mergifyio backport release-2.0 |
|
@Mergifyio backport release-1.4 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2020
Today's existing suspect logic has a periodic checker, which checks every 10s if the Raft cluster still has quorum. If the cluster has lost quorum, it marks the time this event begins, then, every 10s checks to see if 'enough' time has elapsed since the quorum was lost to suspect that the OSN has been evicted. If the OSN has not been evicted, or cannot determine its eviction status, then every 10s the OSN attempts to re-check its suspicion status, which can lead to large volumes of network traffic, especially in significiantly multichannel environments. This commit modifies the logic to track the number of times that the suspect checking logic has actually executed, to ensure that we check no more than once every suspect interval (by default every 10m, instead of every 10s). Signed-off-by: Jason Yellick <jyellick@us.ibm.com> (cherry picked from commit c90015c)
|
Command
|
|
Command
|
|
Command
|
lindluni
pushed a commit
that referenced
this pull request
Jul 15, 2020
Today's existing suspect logic has a periodic checker, which checks every 10s if the Raft cluster still has quorum. If the cluster has lost quorum, it marks the time this event begins, then, every 10s checks to see if 'enough' time has elapsed since the quorum was lost to suspect that the OSN has been evicted. If the OSN has not been evicted, or cannot determine its eviction status, then every 10s the OSN attempts to re-check its suspicion status, which can lead to large volumes of network traffic, especially in significiantly multichannel environments. This commit modifies the logic to track the number of times that the suspect checking logic has actually executed, to ensure that we check no more than once every suspect interval (by default every 10m, instead of every 10s). Signed-off-by: Jason Yellick <jyellick@us.ibm.com> (cherry picked from commit c90015c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Today's existing suspect logic has a periodic checker, which checks
every 10s if the Raft cluster still has quorum. If the cluster has lost
quorum, it marks the time this event begins, then, every 10s checks to
see if 'enough' time has elapsed since the quorum was lost to suspect
that the OSN has been evicted.
If the OSN has not been evicted, or cannot determine its eviction
status, then every 10s the OSN attempts to re-check its suspicion
status, which can lead to large volumes of network traffic, especially
in significiantly multichannel environments.
This commit modifies the logic to track the number of times that the
suspect checking logic has actually executed, to ensure that we check no
more than once every suspect interval (by default every 10m, instead of
every 10s).
-->