-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-18191] Remove contents of leveldb dir instead of the dir itself when dropping dbs #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci-run |
AZP build triggered! |
/ci-run |
AZP build triggered! |
manish-sethi
reviewed
Sep 1, 2020
…when dropping dbs When dropping a leveldb, remove all contents of the directory instead of the directory itself. This is common code for upgrade-dbs, rebuild, reset, and rollback. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
wenjianqiao
force-pushed
the
fab18191
branch
from
September 1, 2020 21:08
c0117a0
to
7b2a1df
Compare
/ci-run |
AZP build triggered! |
manish-sethi
approved these changes
Sep 2, 2020
@Mergifyio backport release-2.2 |
Command
|
denyeart
pushed a commit
that referenced
this pull request
Sep 2, 2020
…when dropping dbs (#1828) When dropping a leveldb, remove all contents of the directory instead of the directory itself. This is common code for upgrade-dbs, rebuild, reset, and rollback. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
When dropping a leveldb, remove all contents of the directory instead of the directory itself.
Additional details
This is common code for upgrade-dbs, rebuild, reset, and rollback. It does not impact ledger rebuild function. The change is requested because some leveldb directories (e.g., StateLevelDB) may be mounted and therefore cannot be deleted.
Related issues
https://jira.hyperledger.org/browse/FAB-18191