FAB-17911 Ch.Part.API: join system channel #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An orderer without channels joins the system channel. It must be a member of the system channel cluster as well. 1. The join-block is saved to the join-block filerepo. 2. If the join-block.number=0, it is appended to the ledger. 3. A degenerate ChainSupport is created, holding an inactive.Chain within, and set into the chains map and the "systemChannel" field. This is done to prevent further invocations to the API from issuing conflicting commands, as they will find a system channel there. 4. Only "List" and "Remove" will be accepted. Transactions sent to the system channel will be rejected. 5. As soon as the Join REST call returns successfully the orderer should be restarted. 6. Upon restart, (boostrapMethod="none") 'Main' will look for a system channel join block, and if it finds one, will treat it as a bootstrap block. 7. Normal boot then resumes, and the orderer will on-board (replicate) the system channel and any channel referred by it, just as if we had boostrapMethod="file" with the same block as bootstrap block. 8. After replication ends, the system channel join block is removed. 9. The orderer now operates in the "legacy" system channel mode. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ief7511de61eccc876f83157315bca98f9e30397c
jyellick
approved these changes
Sep 17, 2020
| bccsp bccsp.BCCSP, | ||
| ) (*ChainSupport, error) { | ||
| cs := &ChainSupport{ledgerResources: ledgerResources} | ||
| cs.Processor = msgprocessor.NewStandardChannel(cs, msgprocessor.CreateStandardChannelFilters(cs, config), bccsp) |
There was a problem hiding this comment.
I would have thought this field would be safe to leave uninitialized? What path is the processor for this channel called? If it's in the broadcast/deliver path, perhaps we'd be better off explicitly returning an error of some sort?
There was a problem hiding this comment.
It is in the broadcast path. The first is "ClasifyHeader" and then "Process*" which will ultimately get to the inactive.Chain which is primed with an informative error message. We'll test that in IT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An orderer without channels joins the system channel.
It must be a member of the system channel cluster as well.
within, and set into the chains map and the "systemChannel" field.
This is done to prevent further invocations to the API from issuing
conflicting commands, as they will find a system channel there.
system channel will be rejected.
be restarted.
channel join block, and if it finds one, will treat it as a bootstrap block.
system channel and any channel referred by it, just as if we had
boostrapMethod="file" with the same block as bootstrap block.
Signed-off-by: Yoav Tock tock@il.ibm.com
Change-Id: Ief7511de61eccc876f83157315bca98f9e30397c
Type of change
Related issues
Task: FAB-17911
Epic: FAB-17712