Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address review comments (#1886) #1890

Merged
merged 1 commit into from
Sep 17, 2020
Merged

address review comments (#1886) #1890

merged 1 commit into from
Sep 17, 2020

Conversation

cendhu
Copy link
Contributor

@cendhu cendhu commented Sep 17, 2020

Type of change

  • Improvement (improvement to code)

Description

Addressed review comments: #1886

@cendhu
address review comments
2a5ba26 
Signed-off-by: Senthil Nathan N <cendhu@gmail.com>
@cendhu cendhu requested a review from a team as a code owner September 17, 2020 12:30
@denyeart denyeart mentioned this pull request Sep 17, 2020
Merged
@manish-sethi manish-sethi merged commit 6bf0542 into hyperledger:master Sep 17, 2020
@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify
Copy link

mergify bot commented Sep 17, 2020

Command backport release-2.2: failure

No backport have been created

  • Backport to branch release-2.2 failed

Cherry-pick of 6bf0542 has failed:

On branch mergify/bp/release-2.2/pr-1890
Your branch is up to date with 'origin/release-2.2'.

You are currently cherry-picking commit 6bf0542ed.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   core/ledger/kvledger/tests/missing_pvtdata_retrieval_test.go
	modified:   internal/peer/node/config.go
	modified:   internal/peer/node/config_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   core/ledger/pvtdatastorage/store_test.go

denyeart pushed a commit to denyeart/fabric that referenced this pull request Sep 17, 2020
@cendhu @denyeart
address review comments (hyperledger#1890)
fc3cc76 
Signed-off-by: Senthil Nathan N <cendhu@gmail.com>
Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@denyeart
Copy link
Contributor

Cherry picked to release-2.2: #1893

manish-sethi pushed a commit that referenced this pull request Sep 17, 2020
@denyeart @cendhu
address review comments (#1890) (#1893)
c5c1105 
Signed-off-by: Senthil Nathan N <cendhu@gmail.com>
Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Co-authored-by: Senthil Nathan N <cendhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manish-sethi manish-sethi manish-sethi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cendhu @denyeart @manish-sethi