[FAB-17691] Add BootstrappingSnapshotInfo to BlockchainInfo #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a block store is created from a snapshot, adding BootstrappingSnapshotInfo to BlockchainInfo. If the store is created from a genesis block, this field is nil. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
wenjianqiao
force-pushed
the
bcinfosnapshot
branch
from
e287e53 to
e1cad2d
Compare
manish-sethi
approved these changes
Sep 25, 2020
| @@ -139,6 +151,9 @@ func TestImportFromSnapshot(t *testing.T) { | |||
| Height: snapshotInfo.LastBlockNum + 1, | |||
| CurrentBlockHash: snapshotInfo.LastBlockHash, | |||
| PreviousBlockHash: snapshotInfo.PreviousBlockHash, | |||
| BootstrappingSnapshotInfo: &common.BootstrappingSnapshotInfo{ | |||
| LastBlockInSnapshot: uint64(snapshotInfo.LastBlockNum), | |||
There was a problem hiding this comment.
Here and at other places, casting is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
When a block store is created from a snapshot, adding BootstrappingSnapshotInfo to BlockchainInfo.
If the store is created from a genesis block, this field is nil.
Related issues
https://jira.hyperledger.org/browse/FAB-17691