Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAB-18082] Make RemoveChannel crash fault tolerant #1952

Merged
merged 1 commit into from
Oct 21, 2020
Merged

[FAB-18082] Make RemoveChannel crash fault tolerant #1952

merged 1 commit into from
Oct 21, 2020

Conversation

stephyee
Copy link
Contributor

Type of change

  • New feature
  • Improvement (improvement to code, performance, etc)

Description

Implement filestore to make remove operation crash fault tolerant

Related issues

FAB-18082

@stephyee stephyee marked this pull request as ready for review October 1, 2020 13:02
@stephyee stephyee requested a review from a team as a code owner October 1, 2020 13:02
@stephyee stephyee marked this pull request as draft October 1, 2020 15:08
@stephyee stephyee force-pushed the fab-18082 branch 4 times, most recently from 7cae879 to 9b4c5f0 Compare October 7, 2020 14:14
@stephyee stephyee marked this pull request as ready for review October 7, 2020 14:56
wlahti
wlahti reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@wlahti wlahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tiffany! Looking good overall. A few minor requests and one nit for your consideration.

common/ledger/blockledger/fileledger/factory.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory_test.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory_test.go Outdated Show resolved Hide resolved
tock-ibm
tock-ibm reviewed Oct 11, 2020
View reviewed changes
common/ledger/blockledger/fileledger/factory.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory_test.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory_test.go Outdated Show resolved Hide resolved
common/ledger/blockledger/fileledger/factory_test.go Outdated Show resolved Hide resolved
@stephyee stephyee force-pushed the fab-18082 branch 3 times, most recently from 43d902c to d01605e Compare October 12, 2020 19:21
@stephyee
[FAB-18082] Make RemoveChannel crash fault tolerant
21f5856 
Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
@tock-ibm
Copy link
Contributor

Looks good

jyellick
jyellick approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but no need to address here.

common/ledger/blockledger/fileledger/factory.go Show resolved Hide resolved
@jyellick jyellick merged commit 7b2b9f0 into hyperledger:master Oct 21, 2020
@stephyee stephyee deleted the fab-18082 branch October 21, 2020 12:33
@stephyee stephyee restored the fab-18082 branch October 27, 2020 18:07
@stephyee stephyee deleted the fab-18082 branch October 27, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlahti wlahti wlahti left review comments

@tock-ibm tock-ibm tock-ibm approved these changes

@jyellick jyellick jyellick approved these changes

Assignees
No one assigned
Labels
channel-participation-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephyee @tock-ibm @jyellick @wlahti @C0rWin