[FAB-17800] Reset/Rollback returns error if a channel was bootstrapped from a snapshot #1990
Conversation
|
/ci-run |
|
AZP build triggered! |
| require.NoError(t, err) | ||
| return len(requests) == 0 | ||
| } | ||
| require.Eventually(t, snapshotGenerated, time.Minute, 100*time.Millisecond) |
There was a problem hiding this comment.
100ms seem unnecessarily long to me...
There was a problem hiding this comment.
The sample ledger has 9 blocks. When running UT locally, there were the following timestamps, so the elapsed time was 337-202=135ms.
2020-10-09 16:21:59.202 EDT [kvledger] func2 -> INFO 1dd^[[0m Generating snapshot channelID=testLedgerFromSnapshot lastCommittedBlockNumber=8
2020-10-09 16:21:59.337 EDT [kvledger] func2 -> INFO 200^[[0m Generated snapshot channelID=testLedgerFromSnapshot lastCommittedBlockNumber=8
…d from a snapshot Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
wenjianqiao
force-pushed
the
resetrollback
branch
from
fc0c7be to
5e978b7
Compare
|
/ci-run |
|
AZP build triggered! |
|
/ci-run |
|
AZP build triggered! |
1 similar comment
|
AZP build triggered! |
|
/ci-run |
|
AZP build triggered! |
| require.NoError(t, os.MkdirAll(ledgerChainDir, 0755)) | ||
| file, err := os.Create(filepath.Join(ledgerChainDir, bootstrappingSnapshotInfoFile)) | ||
| require.NoError(t, err) | ||
| defer file.Close() |
There was a problem hiding this comment.
better to remove "defer"
|
This PR seems stuck in the docs build but otherwise there is no docs related changes. |
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17800