Print Channel Name as String in Gossip Log #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe just add a Stringer? |
|
🤦 Done |
Channel names are currently byte arrays in the logs, add stringer to convert the to string when printing Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
yacovm
approved these changes
Oct 15, 2020
|
timer.Reset() |
|
@Mergifyio backport release-2.2 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
Channel names are currently byte arrays in the logs, add stringer to convert the to string when printing Signed-off-by: Brett Logan <brett.t.logan@ibm.com> (cherry picked from commit d43e5dd) # Conflicts: # gossip/gossip/gossip_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel names are currently byte arrays in the logs, convert them to string.
Signed-off-by: Brett Logan brett.t.logan@ibm.com