Chan.Part.API: join system channel using config block IT #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlahti
changed the title
jyellick
reviewed
Nov 9, 2020
| @@ -968,6 +1096,80 @@ func applicationChannelGenesisBlock(n *nwo.Network, orderers []*nwo.Orderer, p * | |||
| return genesisBlock | |||
| } | |||
|
|
|||
| func systemChannelGenesisBlock(n *nwo.Network, orderers []*nwo.Orderer, peers []*nwo.Peer, channel string) *common.Block { | |||
There was a problem hiding this comment.
This seems to be duplication of the existing logic for bootstrapping a network. Did you look at simply re-using what's already present via nwo?
There was a problem hiding this comment.
The key difference is the flexibility of including different orderers in the consenters set without having a different configtx.yaml (or template). By default, nwo includes all orderers in the consenters set and the endpoints.
Use the configtx library to create the system channel genesis block, as it provides an easy way in tests for explicit control over the orderer endpoints and consenters for a channel. FAB-18273 Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
FAB-18273 Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
These were used previously but not any longer and should be removed. Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
jyellick
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
First commit:
Second commit:
Third commit:
Related issues
FAB-18273