[FAB-18329] Fix data race in cluster/comm_test#TestRenewCertificates #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caod123
previously approved these changes
Nov 9, 2020
caod123
previously approved these changes
Nov 9, 2020
This commit fixes a data race in orderer/common/cluster/comm_test.go#TestRenewCertificates. The race occurred because the TLS configuration was updated from the test goroutine, while a gRPC connection was being established from another goroutine, and as a result, the TLS configuration was loaded without memory synchronization with the first goroutine. I made the test close the gRPC connections before reconfiguring the communication layer. Change-Id: I82b9cc685e9160e480ce77ec7e0a233b106eb0e5 Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
caod123
approved these changes
Nov 9, 2020
Yet it failed the first time it ever ran in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a data race in orderer/common/cluster/comm_test.go#TestRenewCertificates.
The race occurred because the TLS configuration was updated from the test goroutine,
while a gRPC connection was being established from another goroutine, and as a result,
the TLS configuration was loaded without memory synchronization with the first goroutine.
I made the test close the gRPC connections before reconfiguring the communication layer.
Change-Id: I82b9cc685e9160e480ce77ec7e0a233b106eb0e5
Signed-off-by: Yacov Manevich yacovm@il.ibm.com