Add snapshots to peer deploy checklist #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rootDir: /var/hyperledger/production/snapshots | ||
| ``` | ||
|
|
||
| - **`ledger.snapshots.rootDir:`** (Default value should be overridden.) This is the path to where snapshots are stored on the local filesystem of the peer. It can be an absolute path or relative to `FABRIC_CFG_PATH` and defaults to `/var/hyperledger/production/snapshots`, further organized by the status, channel name, and block number of the snapshot. For example, `{ledger.snapshots.rootDir}/completed/{channelName}/{lastBlockNumberInSnapshot}`. The user running the peer needs to own and have write access to this directory. |
There was a problem hiding this comment.
further organized by the status, channel name, and block number of the snapshot. For example, `{ledger.snapshots.rootDir}/completed/{channelName}/{lastBlockNumberInSnapshot}.
I don't think that this portion makes sense at this level. However, if you want to keep this, then it's better to clarify that user does not have to configure anything for this. Also, there is no other status as such. So, I would rewrite this as - Peer node generates the snapshot for a channel at a specific block number under in a directory {ledger.snapshots.rootDir}/completed/{channelName}/{lastBlockNumberInSnapshot}
Change-Id: If4f87761b9af1ea2941cc23dd0266f7f52512315 Signed-off-by: joe-alewine <Joe.Alewine@ibm.com>
joealewine
force-pushed
the
peerdeploysnapshot
branch
from
d397fe3 to
0c7afca
Compare
manish-sethi
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: If4f87761b9af1ea2941cc23dd0266f7f52512315
Signed-off-by: joe-alewine Joe.Alewine@ibm.com
Type of change
Description
Add snapshot parameter to peer deployment guide. Specifically, the "checklist" documenting parameters in core.yaml.