-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chan.Part.API: reduce flakiness after removing system channel #2111
Conversation
0b5d95f
to
b7a1f71
Compare
This isn't a fix yet but it does reduce the frequency of the flake. The issue is we don't have a reliable way to ensure a Raft leader has been elected for the channel participation tests. The existing For the record, this has run successfully three times so far. Going to try one more and then see if we can get this in. |
Seems like part of the flakiness is around orderer3 sometimes not realizing its been evicted from the channel (removed from the consenter set) in time. Currently seeing if reducing the EvictionSuspicion from 10s to 5s helps there. Rolling success count: 5 |
Alright, the test itself worked 5 times in a row with the EvictionSuspicion config change. Going to clean this up and move it to review. This still isn't the total long term fix but it should greatly reduce the frequency of the flakes in this test for now. |
Perform the transaction submission for the application channel that existed before removing the system channel at the end of the test. This gives those chains more time to find a raft leader before they are used. Also change the EvictionSuspicion time from 10s to 5s as the orderer occasionally doesn't notice its been evicted before the test times out. FAB-18305 Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
Type of change
Description
Perform the transaction submission for the application channel that existed before removing the system channel at the end of the test. This gives that channel more time to find a raft leader before we check that it's functioning properly. This seems to reduce the flakiness but it still needs work.
Related issues
FAB-18305