Add check for invalid key before hitting couchdb #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAB-13897 Signed-off-by: manish <manish.sethi@gmail.com>
cendhu
reviewed
Nov 17, 2020
Comment on lines
+529
to
+531
| if err := validateKey(key); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
If the goal is to avoid sending invalid keys to CouchDB but not to the cache, this PR LGTM. Is that the goal? If not, we need to perform this check before accessing the cache also.
There was a problem hiding this comment.
Cache would eventually be populated from DB content only. So, checking in cache does not add any value. Rather, in the current way, it amortizes the cost of this check.
denyeart
approved these changes
Nov 17, 2020
cendhu
approved these changes
Nov 17, 2020
|
@Mergifyio backport release-2.2 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2020
FAB-13897 Signed-off-by: manish <manish.sethi@gmail.com> (cherry picked from commit 5f2034f) # Conflicts: # core/ledger/kvledger/txmgmt/statedb/statecouchdb/statecouchdb_test.go
denyeart
pushed a commit
to denyeart/fabric
that referenced
this pull request
Nov 17, 2020
FAB-13897 Signed-off-by: manish <manish.sethi@gmail.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
manish-sethi
added a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: manish manish.sethi@gmail.com
Type of change
Related issues
FAB-13897