Update core.yaml, orderer.yaml and docs for TLS #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update TLS instructions in yaml files and docs. Specifically, indicate that TLS CA certs and client TLS CA certs do not need to be configured on every peer and orderer, since peers and orderers automatically use the TLS CA certs that exist in the channel configuration. However, additional TLS CA certs can be configured for peers and orderers to augment the list of TLS CA certs from the channel configuration. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
jyellick
reviewed
Nov 17, 2020
| file: tls/ca.crt | ||
| # If mutual TLS is enabled, clientRootCAs.files contains a list of additional root certificates | ||
| # used for verifying certificates of client connections. | ||
| # It is not required to be set, but can be used to augment the set of TLS CA certificates |
There was a problem hiding this comment.
I don't think this is quite right... if you require client auth, and you do not set this, how can you join a peer to a channel? It's only 'not required' once your peer has channels.
There was a problem hiding this comment.
I think he meant it is not required to be set since the mutual TLS is also not required
yacovm
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Update TLS instructions in yaml files and docs.
Specifically, indicate that TLS CA certs and client TLS CA certs do not
need to be configured on every peer and orderer, since peers and orderers
automatically use the TLS CA certs that exist in the channel configuration.
However, additional TLS CA certs can be configured for peers and orderers to
augment the list of TLS CA certs from the channel configuration.
Signed-off-by: David Enyeart enyeart@us.ibm.com